chore(docs): authwit note, not simulating simulations#9438
Merged
critesjosh merged 11 commits intomasterfrom Nov 5, 2024
Merged
chore(docs): authwit note, not simulating simulations#9438critesjosh merged 11 commits intomasterfrom
critesjosh merged 11 commits intomasterfrom
Conversation
critesjosh
changed the title
Collaborator
Docs PreviewHey there! 👋 You can check your preview at https://672a30cb499765aa9ea2edd2--aztec-docs-dev.netlify.app |
| Also, most uses of the approvals are for contracts where the following interactions are called by the user themselves, so it is not a big issue that they are not as easily "transferrable" as the `permit`s. | ||
|
|
||
| :::note | ||
|
|
Contributor
There was a problem hiding this comment.
add this will change in future testnet launches
Contributor
rahul-kothari
left a comment
rahul-kothari
left a comment
There was a problem hiding this comment.
left one minor commment. Should merge have nico is happy with the simulating simulation caveat
Thunkar
approved these changes
Nov 4, 2024
Maddiaa0
pushed a commit
that referenced
this pull request
Nov 6, 2024
Adds notes to the docs that indicate that authwits only work in single player mode, describes the problems with not simulating simulations, and updates the bberg readme install instructions closes AztecProtocol/dev-rel#422 closes AztecProtocol/dev-rel#433 closes #9256 closes AztecProtocol/dev-rel#423 closes #6865
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds notes to the docs that indicate that authwits only work in single player mode, describes the problems with not simulating simulations, and updates the bberg readme install instructions
closes AztecProtocol/dev-rel#422
closes AztecProtocol/dev-rel#433
closes #9256
closes AztecProtocol/dev-rel#423
closes #6865